Fix multiple issues with destructuring #1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrink10
commented
Oct 18, 2024
Comment on lines
-5815
to
-5817
| or-binding (get ors sym)] | ||
| (if or-binding | ||
| [sym `(or (get ~fn-arg ~kw) ~or-binding)] |
There was a problem hiding this comment.
This was another latent bug (for all 4 groups below) where we would not provide the default if it was falsey. For nil that likely doesn't matter because nil is already the default for get, but for false this would make it impossible to override with false.
chrisrink10
commented
Oct 18, 2024
Comment on lines
+5844
to
+5849
| [fn-arg | ||
| `(if (seq? ~fn-arg) | ||
| (if (next ~fn-arg) | ||
| (apply hash-map ~fn-arg) | ||
| (first ~fn-arg)) | ||
| ~fn-arg)] |
There was a problem hiding this comment.
Clojure apparently takes sequences and coerces them to maps for map destructuring or, if the sequence is only a single element, takes the first arg as if it were a map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1078
Fixes #1090